elegant-scipy / elegant-scipy

1st Edition of Elegant SciPy (O'Reilly Publishers)
Other
553 stars 208 forks source link

Ch4: split single signal, multi signal, and real data examples #132

Open jni opened 8 years ago

jni commented 8 years ago

elegant-scipy-ch4.pdf

jni commented 8 years ago

@stefanv Some of these are easier than others, but I've added the easy tag for the ones that are quite immediate, eg. pulling the code comments out.

stefanv commented 8 years ago

OK, OK, I get the idea with the urgent, important, AND easy tags ;)

stefanv commented 8 years ago

Good comments, thank you @jni. Except I'm not sure why your PEP8 checker is flaring up at the point indicated?

jni commented 8 years ago

@stefanv I purposefully omitted another potentially-useful tag: "mostly boring busywork". =P But it does have to be done!

I'm not sure what PEP8 is doing but it's whatever's built into the notebook. Ignore it for now!

hdashnow commented 8 years ago

@stefanv can we tick some of this stuff off? @jni does whatever remains still warrant urgent status?

hdashnow commented 8 years ago

Another suggestion: Define azimuth when it first appears (I didn't figure out what it was until the figure, which is a great figure BTW)

jni commented 8 years ago

which is a great figure BTW

I agree! 👏 👏 👏

jni commented 8 years ago

does whatever remains still warrant urgent status?

This is a good question. Probably not! Removing! (But it does warrant easy and important... =) I also think either one of us could do it at this point, which says a lot about the state of the chapter. =D

stefanv commented 7 years ago

@jni OK to punt on the last remaining point, or to move that to a 2nd ed. fix?

jni commented 7 years ago

@stefanv yes, I'll change the tag and title.