elegantthemes / Divi-Beta

8 stars 0 forks source link

Multiple Selector Issue (bodyFontGroup and FontHeaderGroup) #51

Open dtcblyth opened 10 months ago

dtcblyth commented 10 months ago

Related thread: https://discord.com/channels/1041765492907589683/1079860683623116862/threads/1184742082301149234

Problem:

When specifying multiple selectors and outputting styles for the bodyFont component, the a, ol, ul, and blockquote selectors are only appended to the last selector.

For example, this:

myElement: {
  type:     'object',
  selector: '{{selector}} th, {{selector}} td',
  ...
  decoration: {
    bodyFont: {
      ...
    },
  },
  ...
}

Should output styles like this:

.my_module_01 th a, .my_module_01 td a {
  color: #123456;
}
.my_module_01 th ol, .my_module_01 td ol {
  font-weight: 800;
}
etc...

But actually outputs this:

.my_module_01 th, .my_module_01 td a {
  color: #123456;
}
.my_module_01 th, .my_module_01 td ol {
  font-weight: 800;
}
etc...

Note:

This issue may also affect the headingFont component but I haven’t tested that myself.

dtcblyth commented 1 month ago

Please note, I can verify that this issue also affects the.FontHeaderGroup.

As of Pub-Alpha, this issue seems to be resolved for the BodyFont group. However, the issue is still affecting FontHeaderGroup, and is not yet fixed.