search

elegantthemes / Divi-Beta

8 stars 0 forks source link

Font Weight "Regular" Value Not Converting From D4 to D5 #59

Closed dtcblyth closed 1 month ago

dtcblyth commented 7 months ago

Related thread: https://discord.com/channels/1041765492907589683/1079860683623116862/threads/1199975933969436742

The Problem:

When using the FontGroup, FontBodyGroup, or FontHeaderGroup components and converting from D4 to D5, the Font Weight setting is not always converting correctly.

For example, if we have a FontGroup which is declared in the module.json file to have a default value of bold, like this:

...
"decoration": {
  "font": {
    "font": {
      "desktop": {
        "value": {
          "weight": "700"
        }
      }
    }
  }
}
...

If the user was to set the Font Weight to Medium, or Ultra Bold, and then convert the module from D4 to D5, the value would convert correctly. However, if the user was to set the Font Weight to Regular, and then convert the module from D4 to D5, the value would not covert and would instead fallback to the default Bold value.

robicse11127 commented 1 month ago

As the discussion get resolved, I am going to close this issue here. Discord thread : https://discord.com/channels/1041765492907589683/1199975933969436742/1199975933969436742 If you have more concern please open a new issue. Thanks.