elego / rental-vertical

Stage of Elego Rental Vertical Odoo Modules for OCA
GNU Affero General Public License v3.0
14 stars 29 forks source link

v16 Unable to install rental_base #3

Open etoimene opened 4 months ago

etoimene commented 4 months ago

I gave it a try but unsuccessful.

Element '' cannot be located in parent view

Seems that Parent identification by id does not get the the correct view.


odoo.tools.convert.ParseError: while parsing /home/xxxx/OdooProjects/Odoo16/elego/rental-vertical/rental_base/views/sale_view.xml:63
Error while validating view:

Element '<xpath expr="//group[field[@name=&#39;analytic_tag_ids&#39;]]">' cannot be located in parent view

View error context:
{'file': '/home/xxxx/OdooProjects/Odoo16/elego/rental-vertical/rental_base/views/sale_view.xml',
 'line': 2,
 'name': 'rental_base.view_order_form',
 'view': ir.ui.view(1453,),
 'view.model': 'sale.order',
 'view.parent': ir.ui.view(1331,),
 'xmlid': 'view_order_form'}
etoimene commented 4 months ago

sale_rental.view_order_form that I have does not have analytic_tag_ids

Which sale_rental is this elego version based on?

15.0 does not have that tags either. https://github.com/OCA/sale-workflow/blob/15.0/sale_rental/views/sale_rental.xml

olaf-wagner commented 4 months ago

Der Code ist noch nicht auf v16 portiert. Die hoechste funktionierende Version ist v15. Sorry, need to speak English here of course. The code hasn't been ported yet to version 16. The hightest supported Odoo version currently is 15.

olaf-wagner commented 4 months ago

@mrgoetz can you check if there is problem regarding these tags in v15?

rental_base//views/sale_view.xml:                expr="//group[field[@name='analytic_tag_ids']]"
rental_base//views/sale_view.xml:            <!-- <xpath expr="//label[@for='analytic_tag_ids']" position="attributes">
rental_base//views/sale_view.xml:            <xpath expr="//field[@name='analytic_tag_ids']" position="attributes">
rental_base//views/sale_view.xml:                        for="analytic_tag_ids"
rental_base//views/sale_view.xml:                        groups="analytic.group_analytic_tags"
rental_base//views/sale_view.xml:                            name="analytic_tag_ids"
rental_base//views/sale_view.xml:                            groups="analytic.group_analytic_tags"

If so, perhaps an integration a feature or fix branch is missing?

mrgoetz commented 4 months ago

@etoimene @olaf-wagner

as far as I could test, the rental-vertical modules run with version 15.

The view in rental_base//views/sale_view.xml having ...expr="//group[field[@name='analytic_tag_ids']]"...

inherits from the core module "sale" and here we find the view "view_order_form" and: <field name="analytic_tag_ids"

See https://github.com/odoo/odoo/blob/15.0/addons/sale/views/sale_views.xml

Hope that helps.