search

elekto-io / elekto

Software for the Elekto online elections system
https://elekto.io
Apache License 2.0
31 stars 20 forks source link

Election should say "ended" if you visit it after it ends #79

Open craigbox opened 2 years ago

craigbox commented 2 years ago

The election is marked "completed", so the tenses of the start/end time listed at the bottom should be "started" and "ended"

Screen Shot 2022-10-17 at 1 36 48 PM
jberkus commented 2 years ago

I don't follow?

bannmann commented 7 months ago

@jberkus Just stumbled over this. I think what OP meant was that in the screenshot, the last line reads:

Voting starts at 2022-10-03 UTC and ends at 2022-10-16 11:59:59 UTC.

However, the screenshot was clearly made after the election was over (as it says "Completed" below the heading). So "starts at" and "ends at" are confusing. So for completed elections, the text should change as follows:

Voting startsstarted at 2022-10-03 UTC and endsended at 2022-10-16 11:59:59 UTC.

jberkus commented 7 months ago

Makes sense. That seems like a good small change for a new contributor, so reopening.