element-hq / compound

Element's design system
https://compound.element.io
Apache License 2.0
11 stars 3 forks source link

Avatar component #137

Open nadonomy opened 1 year ago

nadonomy commented 1 year ago

Component name

Avatar

Figma link

# Design phase
- [x] Design phase for Web
- [x] Design phase for iOS
- [x] Design phase for Android
# Development phase
- [ ] https://github.com/vector-im/compound-web/pull/4
- [ ] Development phase for iOS
- [ ] Development phase for Android
- [ ] https://github.com/matrix-org/sliding-sync/issues/241

Adding a reminder that this work includes reducing the number of avatar sizes across platforms (if it hasn't been done already):

Image

@pixlwave @jmartinesp, message @callumu with any questions


Implementation details

nadonomy commented 1 year ago

Initial thoughts on specs/requirements:

pixlwave commented 1 year ago

Consider using other users avatars when images aren't set.

For Element X this would be a bit more tricky right now as Sliding Sync doesn't provide us with the room members in the room list. If we wanted it, I would image we could add an extension to include the room heroes in the sync response, although a trade-off on that might be increased sync size slowing the app down a bit.

janogarcia commented 1 year ago

@nadonomy @germain-gg Should we remove/merge this older duplicate? https://github.com/vector-im/compound/issues/117