search

element-hq / compound

Element's design system
https://compound.element.io
Apache License 2.0
12 stars 3 forks source link

AvatarStack doesn't allow non-avatar elements in the stack #215

Closed t3chguy closed 1 year ago

t3chguy commented 1 year ago

Element Web's FacePile looks like this:

image

It has an extra overflow tile "..." at the end which follows the stacking behaviour. Due to the styling of compound-web the style is not applied and it ends up not being stacked.

image

image

Either relax the selector or export the class/wrapper element to allow stacking things other than Compound avatars to enable wider reuse. Otherwise code ends up having to work around it and duplicate logic which can de-sync:

image

Partly caused https://github.com/vector-im/element-web/issues/26112

Johennes commented 1 year ago

Once this is done, we should also clean up the temporary workaround made in https://github.com/matrix-org/matrix-react-sdk/pull/11527.

t3chguy commented 1 year ago

This was fixed by @germain-gg