element-hq / compound

Element's design system
https://compound.element.io
Apache License 2.0
12 stars 3 forks source link

ToggleMenuItem requires both onChange and onSelect #288

Open robintown opened 11 months ago

robintown commented 11 months ago

Platform

Web

Package version

Description

If you don't provide onChange to ToggleMenuItem, then you get this warning:

image(1)

And if you don't provide onSelect, then you get this error:

image(2)

Semantically, these props are redundant to each other, and we should unify them. It's not at all clear which functions the two callbacks are meant to serve.

MidhunSureshR commented 2 months ago

Fixed by https://github.com/element-hq/compound-web/pull/229?