element-hq / compound

Element's design system
https://compound.element.io
Apache License 2.0
12 stars 3 forks source link

Updates to / unification of Floating Menu #308

Open americanrefugee opened 10 months ago

americanrefugee commented 10 months ago

Figma document

Storybook pages

Platform

Updates requested

There should just be 1 component with the following variants:

robintown commented 10 months ago

Some notes to myself:

The fact that a single menu can contain multiple headers (the sort list example), and these headers can contain arbitrary content (the account example) suggests that I should extract out a separate header component in the implementation. And when the menu header disappears in the bottom sheet version, we can implement this by saying that the menu component has an inherent (optional) header slot.

I need to think a bit harder about how to get keyboard navigation to behave correctly in each of these variants, and what the best way would be to provide shortcut components for creating nav lists and option lists.

americanrefugee commented 10 months ago

I also noticed that the margins are incorrect in the current implementation...