search

element-hq / compound

Element's design system
https://compound.element.io
Apache License 2.0
12 stars 3 forks source link

Build with Vite #311

Closed robintown closed 6 months ago

robintown commented 9 months ago

Vite is a significantly faster builder than Webpack which the JS ecosystem seems to be adopting widely. We're already using it successfully for Compound Web, and Storybook makes it pretty simple to swap it out for Webpack, so that's what I've done here.

benbz commented 9 months ago

As per discussion with @dbkr the Cloudflare failure is because vite requires a newer version of Node than we have configured. https://gitlab.matrix.org/infrastructure/cloudflare/-/merge_requests/232 to change this in preview, will also need changing in production once confirmed it works and is safe to do

cloudflare-workers-and-pages[bot] commented 9 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f2ff3e9
Status: ✅  Deploy successful!
Preview URL: https://6d50c199.compound-5m4.pages.dev
Branch Preview URL: https://vite.compound-5m4.pages.dev

View logs

robintown commented 6 months ago

@benbz Can we go ahead and change the Node version in production? The preview is working, so I'm ready to merge this once production is updated.

benbz commented 6 months ago

https://gitlab.matrix.org/infrastructure/cloudflare/-/merge_requests/236 for production. Good for me to merge and apply?