element-hq / compound

Element's design system
https://compound.element.io
Apache License 2.0
12 stars 3 forks source link

Icons from the "Icons" folder are not displayed when running Web Element using apache2. #321

Open ELForcer opened 8 months ago

ELForcer commented 8 months ago

Steps to reproduce

  1. Launch the browser
  2. Open Web Element
  3. Open any dialog box.
  4. Make sure there is no close button.

Outcome

What did you expect?

Show icons

What happened instead?

Error 404

Icons from the "Icons" folder are not displayed when running Web Element using apache2.

The problem lies in the new "icons" folder since at least version 1.11.46. v1.11.39 did not have an "icons" folder and the icons were in the "img" folder.

The reason why icons from the "icons" folder are not displayed is the default Apache settings in the file /etc/apache2/mods-enabled/alias.conf which looks like this:

<IfModule alias_module>
# Aliases: Add here as many aliases as you need (with no limit). The format is
# Alias fakename realname
#
# Note that if you include a trailing / on fakename then the server will
# require it to be present in the URL. So "/icons" isn't aliased in this
# example, only "/icons/". If the fakename is slash-terminated, then the
# realname must also be slash terminated, and if the fakename omits the
# trailing slash, the realname must also omit it.
#
# We include the /icons/ alias for FancyIndexed directory listings. If
# you do not use FancyIndexing, you may comment this out.

Alias /icons/ "/usr/share/apache2/icons/"

<Directory "/usr/share/apache2/icons">
Options FollowSymlinks
AllowOverride None
Require all granted
</Directory>

</IfModule>

# vim: syntax=apache ts=4 sw=4 sts=4 sr noet

A quick solution is to comment out the line: Alias /icons/ "/usr/share/apache2/icons/"

But it's better to rename the "icons" folder to something else.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

Web Element 1.11.62

Homeserver

No response

Will you send logs?

No

t3chguy commented 8 months ago

Looks like the path is determined by https://github.com/element-hq/compound-design-tokens/tree/main/icons

Justinzobel commented 1 month ago

Thanks for this @ELForcer!