element-hq / dendrite

Dendrite is a second-generation Matrix homeserver written in Go!
https://element-hq.github.io/dendrite/
GNU Affero General Public License v3.0
11 stars 3 forks source link

Create events shouldn't have prev_event information #1742

Open matrixbot opened 2 weeks ago

matrixbot commented 2 weeks ago

This issue was originally created by @turt2live at https://github.com/matrix-org/dendrite/issues/1742.

image

Nothing under unsigned in that screenshot should exist.

matrixbot commented 2 weeks ago

This comment was originally posted by @neilalexander at https://github.com/matrix-org/dendrite/issues/1742#issuecomment-770028699.

@Kegsay Do you know what's going on here?

matrixbot commented 2 weeks ago

This comment was originally posted by @kegsay at https://github.com/matrix-org/dendrite/issues/1742#issuecomment-770908468.

No idea. I think the syncapi sets unsigned when updating the room state table or something. https://github.com/matrix-org/dendrite/blob/9f443317bc578e1897c7eab9b4911f952f39fdbc/syncapi/consumers/roomserver.go#L378 so perhaps we see the create event twice in the roomserver output stream?

matrixbot commented 2 weeks ago

This comment was originally posted by @kegsay at https://github.com/matrix-org/dendrite/issues/1742#issuecomment-877096752.

This is almost certainly the case. We know that the roomserver can emit the same events multiple times.