search

element-hq / dendrite

Dendrite is a second-generation Matrix homeserver written in Go!
https://element-hq.github.io/dendrite/
GNU Affero General Public License v3.0
33 stars 5 forks source link

Implement token-authenticated registration #3097

Open matrixbot opened 3 weeks ago

matrixbot commented 3 weeks ago

This issue was originally created by @S7evinK at https://github.com/matrix-org/dendrite/issues/3097.

Spec version 1.2 introduced token-authenticated registration and a new client API endpoint (MSC3231), this is currently missing.

GET /_matrix/client/v1/register/m.login.registration_token/validity spec

To generate tokens, we should use the same admin endpoints as Synapse, so existing tools to create tokens can be used for Dendrite as well.

matrixbot commented 3 weeks ago

This comment was originally posted by @santhoshivan23 at https://github.com/matrix-org/dendrite/issues/3097#issuecomment-1573885828.

@S7evinK - I'd like to take this

matrixbot commented 3 weeks ago

This comment was originally posted by @santhoshivan23 at https://github.com/matrix-org/dendrite/issues/3097#issuecomment-1575017486.

@kegsay - I've started working on the draft PR. Pls assign this issue to me.

matrixbot commented 3 weeks ago

This comment was originally posted by @santhoshivan23 at https://github.com/matrix-org/dendrite/issues/3097#issuecomment-1575076558.

PR #3101 will track this issue

matrixbot commented 3 weeks ago

This comment was originally posted by @santhoshivan23 at https://github.com/matrix-org/dendrite/issues/3097#issuecomment-1602995243.

Implemented with #3101. This can be closed

matrixbot commented 3 weeks ago

This comment was originally posted by @S7evinK at https://github.com/matrix-org/dendrite/issues/3097#issuecomment-1611760495.

Not yet, there is still the missing endpoint GET /_matrix/client/v1/register/m.login.registration_token/validity But that should be a quite short PR, given it is basically the GET /admin/registrationTokens/{token} endpoint.

Also, thank you for having implemented the admin endpoints! :)

matrixbot commented 3 weeks ago

This comment was originally posted by @ghost at https://github.com/matrix-org/dendrite/issues/3097#issuecomment-1868987392.

@S7evinK I'll implement the missing endpoint :)

matrixbot commented 3 weeks ago

This comment was originally posted by @DevSH01 at https://github.com/matrix-org/dendrite/issues/3097#issuecomment-2257547974.

@S7evinK I'll implement the missing endpoint :)

hi, any update on the endpoint implementation?