search

element-hq / dendrite

Dendrite is a second-generation Matrix homeserver written in Go!
https://element-hq.github.io/dendrite/
GNU Affero General Public License v3.0
37 stars 6 forks source link

Update Sentry reporting further #3306

Open matrixbot opened 3 weeks ago

matrixbot commented 3 weeks ago

This issue was originally created by @S7evinK at https://github.com/matrix-org/dendrite/issues/3306.

https://github.com/matrix-org/dendrite/pull/3305 made reporting errors a bit better, but there are still places in the code where we CaptureException in go routines, possibly still sending garbage to Sentry. For reference: https://docs.sentry.io/platforms/go/usage/concurrency/

It may also make sense to check if we even should report said errors to sentry, as e.g. we should always be able json.Unmarshal things we sent to JetStream ourselves.