element-hq / dendrite

Dendrite is a second-generation Matrix homeserver written in Go!
https://element-hq.github.io/dendrite/
GNU Affero General Public License v3.0
33 stars 5 forks source link

account reactivation #3309

Closed matrixbot closed 2 weeks ago

matrixbot commented 2 weeks ago

This issue was originally created by @TruncatedDinoSour at https://github.com/matrix-org/dendrite/issues/3309.

Description:

synapse has account reactivation, but i don't think dendrite has that, would be a useful feature, esp rn as i'm sorta in need of it xD

matrixbot commented 2 weeks ago

This comment was originally posted by @spaetz at https://github.com/matrix-org/dendrite/issues/3309#issuecomment-1906981541.

You can poke the user_account table and reactivate directly there....

matrixbot commented 2 weeks ago

This comment was originally posted by @TruncatedDinoSour at https://github.com/matrix-org/dendrite/issues/3309#issuecomment-1907007421.

You can poke the user_account table and reactivate directly there....

yeah but thts very uh hacky

matrixbot commented 2 weeks ago

This comment was originally posted by @jjj333-p at https://github.com/matrix-org/dendrite/issues/3309#issuecomment-1931257352.

i mean deactivation only exists by either poking the db or logging in as the user and using the user endpoint, so like of course it wont exist.

also imo it shouldnt be added but thats just my personal take

matrixbot commented 2 weeks ago

This comment was originally posted by @TruncatedDinoSour at https://github.com/matrix-org/dendrite/issues/3309#issuecomment-1931327211.

i mean deactivation only exists by either poking the db or logging in as the user and using the user endpoint, so like of course it wont exist.

also imo it shouldnt be added but thats just my personal take

synapse has it and i think itd come in handy when u need it https://matrix-org.github.io/synapse/latest/admin_api/user_admin_api.html#create-or-modify-account

deactivated is set to false and the user was previously deactivated (you are reactivating this user)

matrixbot commented 2 weeks ago

This comment was originally posted by @S7evinK at https://github.com/matrix-org/dendrite/issues/3309#issuecomment-1969877953.

Given /deactivate doesn't just set a flag in Dendrite but also removes the user from every room they were in, I'm not sure this is something we currently want to implement.