element-hq / dendrite

Dendrite is a second-generation Matrix homeserver written in Go!
https://element-hq.github.io/dendrite/
GNU Affero General Public License v3.0
33 stars 5 forks source link

Authenticated media requests don't seem to work at all? #3420

Closed matrixbot closed 2 weeks ago

matrixbot commented 2 weeks ago

This issue was originally created by @Lunaphied at https://github.com/matrix-org/dendrite/issues/3420.

Background information

Description

Steps to reproduce

Sep 10 18:08:41 homura dendrite[14339]: time="2024-09-11T00:08:41.576265018Z" level=error msg="r.fetchRemoteFileAndStoreMetadata: failed to fetch remote file" MediaID=redacted Origin=matrix.org error="File with media ID \"redacted\" does not exist on matrix.org" req.id=KiQCE521bkpb req.method=GET req.path=/_matrix/media/v3/download/matrix.org/redacted

all redacteds are the same ID.

matrixbot commented 2 weeks ago

This comment was originally posted by @viviicat at https://github.com/matrix-org/dendrite/issues/3420#issuecomment-2342570170.

Looking at the history, this might be because they have not made a release with that functionality yet? I believe it was added in August in #3397

Tomorrow I'm going to try with a more recent build to see if that resolves it.

matrixbot commented 2 weeks ago

This comment was originally posted by @viviicat at https://github.com/matrix-org/dendrite/issues/3420#issuecomment-2342583887.

Yeah, running from a main build resolved my issue.

matrixbot commented 2 weeks ago

This comment was originally posted by @S7evinK at https://github.com/matrix-org/dendrite/issues/3420#issuecomment-2342689050.

Also keep in mind that you need a client that supports authed media through the unstable feature announced in /versions, as we do not have support for Matrix v1.11 yet.

matrixbot commented 2 weeks ago

This comment was originally posted by @McSinyx at https://github.com/matrix-org/dendrite/issues/3420#issuecomment-2342714158.

What clients would work then?

matrixbot commented 2 weeks ago

This comment was originally posted by @S7evinK at https://github.com/matrix-org/dendrite/issues/3420#issuecomment-2342795634.

AFAIK, FluffyChat and nheko either use the unstable feature, or just try the new endpoints and use them.

matrixbot commented 2 weeks ago

This comment was originally posted by @Lunaphied at https://github.com/matrix-org/dendrite/issues/3420#issuecomment-2344188676.

Looking at the history, this might be because they have not made a release with that functionality yet? I believe it was added in August in #3397

Ah looks like my quick peruse and search of the sources and PRs missed this, thank you! Manually bumping my package to use the latest sources seems to address the issue so the solution for this should be as simple as cutting a new release of dendrite

matrixbot commented 2 weeks ago

This comment was originally posted by @S7evinK at https://github.com/matrix-org/dendrite/issues/3420#issuecomment-2366784813.

3431 was merged, so hopefully some/all of this was fixed, if not, feel free to re-open.