element-hq / dendrite

Dendrite is a second-generation Matrix homeserver written in Go!
https://element-hq.github.io/dendrite/
GNU Affero General Public License v3.0
11 stars 3 forks source link

Fix alias deletion #654

Closed matrixbot closed 2 weeks ago

matrixbot commented 2 weeks ago

This issue was originally created by @babolivier at https://github.com/matrix-org/dendrite/issues/654.

matrixbot commented 2 weeks ago

This comment was originally posted by @anoadragon453 at https://github.com/matrix-org/dendrite/issues/654#issuecomment-505483222.

Keep track of an alias's owner (someone else shouldn't be able to delete an alias I set)

Apparently this is an implementation detail, so we could either prevent room admins from deleting aliases or allow it.

We could also provide a config option for dendrite to let the homeserver admin choose to allow server admins this ability.

matrixbot commented 2 weeks ago

This comment was originally posted by @Cnly at https://github.com/matrix-org/dendrite/issues/654#issuecomment-510823789.

I'll say that we should always allow room and homeserver admins to delete aliases, even if they'll only be able to delete the local ones. This is their control over the room/server. The fact that admins can't remove alias mappings on other servers anyways is making their deleting local aliases less meaningful, but I don't think it makes enough sense either that we remove admins' control over local data because of this.

matrixbot commented 2 weeks ago

This comment was originally posted by @anoadragon453 at https://github.com/matrix-org/dendrite/issues/654#issuecomment-514984191.

The spec says we have free reign here, so let's go for allowing admins to remove local room aliases.