search

element-hq / element-android

A Matrix collaboration client for Android.
https://element.io/
GNU Affero General Public License v3.0
3.37k stars 718 forks source link

Failed messages shouldn't show up in the room list as sent #1125

Open turt2live opened 4 years ago

turt2live commented 4 years ago

This issue is: Waiting for a decision from Design on how to handle room previews when messages are not successfully sent.

Turns out I spent an entire weekend thinking I said something, but the message failed to send. The room list in RiotX used the failed message as preview text, which meant I never bothered to check if it actually sent.

ouchadam commented 2 years ago
ROOM DETAILS ROOM LIST
message-status Screenshot_20211125_114858
daniellekirkwood commented 2 years ago

Can I confirm your suggestion @turt2live - You would prefer that the message preview is the last message successfully sent and received by the room?

That makes sense to me, @ouchadam are there limitations or complications in implementing this?

ouchadam commented 2 years ago

another related proposal that attempts to solve the visibility of failed messages https://github.com/vector-im/element-android/issues/4164

it should doable, would we also want to highlight when there's an error (or the loading status of unsent messages) in the room list?

daniellekirkwood commented 2 years ago

We could even leave the Preview as is but add the Exclamation icon we have underneath/next to the timestamp to highlight that there's an issue in the room...

That's designs call, but if we're able to do something here, we should.

I'm removing the Needs-Product label and leaving the Needs-Design label

turt2live commented 2 years ago

In the short term, yes it'd be nice to have the preview be the last successful message. Ideally it'd be styled differently for failed messages.