search

element-hq / element-android

A Matrix collaboration client for Android.
https://element.io/
GNU Affero General Public License v3.0
3.38k stars 724 forks source link

InApp Camera #1389

Open bmarty opened 4 years ago

bmarty commented 4 years ago

Use inApp Camera to take photo to send them to a room. Using the new CameraX API: https://developer.android.com/training/camerax

For the moment, this feature will be enabled at compilation time. If enabled, the external camera app will never be opened from RiotX.

kojid0 commented 4 years ago

I'd very appreciate if we can still access the external camera if wanted. In-app cameras usually don't have the same quality as the actual external device-camera app. Don't know how the plans for riotx in-app camera look like but maybe long-click on the preview could still open external camera app?

TR-SLimey commented 4 years ago

I doubt anyone would need to switch frequently between the two so a simple setting might be enough. For example, Settings > Preferences > Use system camera.

kojid0 commented 4 years ago

I doubt anyone would need to switch frequently between the two so a simple setting might be enough. For example, Settings > Preferences > Use system camera.

Don't know if we are talking about the same InApp Camera Feature but I thought about something like this (screenshot from Telegram): riotx

By tapping on the camera preview, the InApp Camera opens. Long tapping will activate native camera (better quality).

Please refrain from making yet another setting - IMO there are already have too many which make riot look complicated for "normal" users.

TR-SLimey commented 4 years ago

I see what you mean. Yeah, that makes sense.

omentic commented 3 years ago

What would the benefit of using an in-app camera be? I'm personally always frustrated by this behavior in Discord, because it doesn't allow me to use more advanced camera features.