search

element-hq / element-android

A Matrix collaboration client for Android.
https://element.io/
GNU Affero General Public License v3.0
3.36k stars 717 forks source link

Finding deactivated users in search results and able to create a room #2225

Open chagai95 opened 4 years ago

chagai95 commented 4 years ago

Describe the bug A deactivated user seems to come up in the search results. It was possible to find the user in the search and even to create a room with the deactivated user...

To Reproduce Steps to reproduce the behavior: Search for a deactivated user using the find by matrix id

Expected behavior They shouldn't show in the search results and a room should not be created

Screenshots Here are some screen caps showing the problem: https://photos.app.goo.gl/tEojRTT1ina74fTV9

Tried on matrix.org and it seems to be doing the same there but this time I really had to enter the full ID because for some reason it didn't find anything when I just typed the beginning of the username - probably because I had just created the new user for testing (might be related to Android).

Smartphone (please complete the following information):

Additional context

bmarty commented 4 years ago

It seems that the search user API is returning deactivated users, than. @erikjohnston any though on that?

bmarty commented 4 years ago

(I have not reproduce the issue on my side, with an account which is deactivated since several weeks, so this is maybe a temporary issue, when the account has been just deactivated).