search

element-hq / element-android

A Matrix collaboration client for Android.
https://element.io/
GNU Affero General Public License v3.0
3.33k stars 709 forks source link

Allow aspect ratio free cropping of uploaded images #2356

Closed benparsons closed 1 year ago

benparsons commented 3 years ago

Is your feature request related to a problem? Please describe. You want to share only part of an image, would like to crop it immediately before uploading.

Describe the solution you'd like Tiny editor similar to WhatsApp

Describe alternatives you've considered None, idea stolen from WhatsApp.

T-bond commented 3 years ago

There is already cropping functionality. Just the buttons invisible/black on black. In the current release they are fixed. Screenshot_20201106-205532_Element (Riotim)

SeerLite commented 3 years ago

Isn't that only aspect ratio cropping though? I couldn't figure out how to crop freely like on other apps. I think aspect ratio cropping is really unintuitive, it has been a common complaint from my friends

SeerLite commented 3 years ago

I'd also like to suggest adding some basic editing functionality like the ability to add text or draw on top of images. They're not as important as cropping but still missed a lot from other IMs, in case you wanna consider them.

thefeiter commented 2 years ago

Isn't that only aspect ratio cropping though? I couldn't figure out how to crop freely like on other apps. I think aspect ratio cropping is really unintuitive, it has been a common complaint from my friends

Every time I want to send only part of a screenshot, I have to use my phones built in image editor to be able to crop with a free aspect ratio. I would really love to see free cropping as well. I think those are things making it hard for people to transfer to matrix since all other messenger apps have this as a basic feature.

thefeiter commented 2 years ago

Maybe the issue can be renamed to "Allow aspect ratio free cropping of images"

mxvin commented 2 years ago

This feature is available from upstream libs. See https://github.com/Yalantis/uCrop/issues/801#issuecomment-1018245678 Just add some line on GalleryOrCameraDialogHelper.kt and that's it. This is a very basic feature, important and must be available ASAP :smile: 

UCrop.Options options = new UCrop.Options();
options.setFreeStyleCropEnabled(true);