element-hq / element-android

A Matrix collaboration client for Android.
https://element.io/
Apache License 2.0
3.32k stars 704 forks source link

Tapping drawer having more than 1 room in notifications gives "malformed link" error #2605

Closed olmari closed 3 years ago

olmari commented 3 years ago

Describe the bug When there is multiple notifications for matrix-rooms, when I tap the Element notifications in Android drawer I do get into Element main screen but it always also gives error "Your matrix.to link was malformed".

To Reproduce

  1. Have notification in 2 or more rooms
  2. Click on Element notifications in Android drawer
  3. See error

Expected behavior To get into Element main screen without error popping up.

Screenshots Element_error

Smartphone (please complete the following information):

Additional context

janilahti commented 3 years ago

I can confirm this behavior. OnePlus 7 Pro / Android 10.

WarpedOne commented 3 years ago

Confirmed on Samsung Note 8 / Android 9. Single notification goes to that room, Multiple notices gets the 'malformed link' message.

Error message was commented on in https://github.com/vector-im/element-android/pull/2047#issuecomment-688380382

Looks like the code is in https://github.com/vector-im/element-android/blob/bc889cbcf4b829335d61aa03144cd415370b65ca/vector/src/main/java/im/vector/app/features/matrixto/MatrixToBottomSheetViewModel.kt lines 67-77 string 'permalink_malformed'.

And https://github.com/vector-im/element-android/blob/2b780a8b761b6ba0b9ee5a9c50c979475615e4c3/vector/src/main/java/im/vector/app/features/home/HomeActivity.kt lines 166-198 same 'permalink_malformed'.

scottwallacesh commented 2 years ago

This seems to be happening again.

Nexus2k commented 2 years ago

Happens for me here too. I also think it's when notifications from more than one room are pending.

Android 12 on a Pixel 5

bmarty commented 2 years ago

We track this regression in #4267