element-hq / element-android

A Matrix collaboration client for Android.
https://element.io/
GNU Affero General Public License v3.0
3.38k stars 722 forks source link

URLs dissapear within redacted messages #2718

Closed waclaw66 closed 3 years ago

waclaw66 commented 3 years ago

Describe the bug URLs are not shown within redacted messages on Android unlike web client.

To Reproduce Steps to reproduce the behavior:

  1. Post message with URL on Element Web
  2. Redact text of the message, URL preview stays visible on Element Web
  3. URL dissapears on Android's Element

Expected behavior URL should be intacted and visible on Android.

Smartphone (please complete the following information):

bmarty commented 3 years ago

I'm not sure to understand. If a message containing a URL is redacted, Element Web removes the URL preview, and I think this is the correct behavior.

So I think step 3 is OK.

waclaw66 commented 3 years ago

Element Web doesn't remove the URL preview while redaction, that's ok, but Element on Adnroid removed entire URL, there left only the message. Now I tried it again, and unfortunatelly couldn't reproduce it, the URL stays visible on Android as well. Maybe it has been fixed meanwhile, or it's some random bug. But it definitely happened. I will keep my eye on that.

I'm not sure to understand. If a message containing a URL is redacted, Element Web removes the URL preview, and I think this is the correct behavior.

So I think step 3 is OK.

bmarty commented 3 years ago

Ok, I'm not sure to understand every thing here, but fell free to re-open the issue if you see the bug again