search

element-hq / element-android

A Matrix collaboration client for Android.
https://element.io/
GNU Affero General Public License v3.0
3.37k stars 719 forks source link

Custom login, giving server_name sticks as "matrix server" later #4054

Open olmari opened 3 years ago

olmari commented 3 years ago

Steps to reproduce

  1. Have HS with client .well-known
  2. Go to custom login
  3. Write server_name as asked server (and not the actual url server answers from).
  4. Login
  5. In general settings See "https://server_name" as Homeserver address insated of the actual server address (that well-known resolves into).

What happened?

What did you expect?

To see actual homeserver address in homeserver address field.

What happened?

Setting shows the server_name instead of actual homeserver address.

Your phone model

Multiple

Operating system version

Android 10

Application version and app store

Element 1.2.2 form gplay

Homeserver

hacklab.fi

Have you submitted a rageshake?

No

bmarty commented 3 years ago

If you enable the developer mode (under settings/advanced settings) you will see the homeserver API url.

For regular users, I think this is OK to see the homeserver url they have entered during login phase in this screen.

olmari commented 3 years ago

For regular users, I think this is OK to see the homeserver url they have entered during login phase in this screen.

Most importantly server_address is not the address the field is referring to... And at the least it is inconsistent with other clients, including Element-web. At worst it is misleading if ever actually needed for something.