element-hq / element-android

A Matrix collaboration client for Android.
https://element.io/
Apache License 2.0
3.3k stars 690 forks source link

Add voice processing feature in the voice & video settings #4868

Open archerallstars opened 2 years ago

archerallstars commented 2 years ago

Your use case

What would you like to do?

I want to fine tune the call quality of the app. I don't know whether the voice processing feature that I am requesting has been implemented in the app though.

Docs from Android Developers website:

Why would you like to do it?

How would you like to achieve it?

Include the option in the settings as shown in the screenshot below (the example from Discord):

Voice & Video settings in Discord

Comparing to Element:

Voice & Video settings in Element

Have you considered any alternatives?

This option has to be implemented in the app.

Additional context

No response

ouchadam commented 2 years ago

from a quick look it appears that the libraries we use for voip calls (webrtc-react-native) and video meetings (jitsi-meet) don't appear to expose these options to us

do you know if it's possible @ganfra ?

tdbe commented 2 years ago

+1 for all those reasons and also, I desperately need to be able to turn some of the noise cancellations off! My team often goes in the field and when someone holds the phone at around 1-1.2 meters away, the microphone interrupts the voice every other second because some hidden noise/echo cancellation threshold is triggered.

So it's very hard to use a product with hidden settings. Discord (As much as I dislike it) at least has sliders and threshold meters which show you how it's working, when it's cancelling and when it isn't etc. -- so when we tweak or turn off a bunch of these features, we can hear each other much better.

PS: this is also a big problem: https://www.quora.com/Why-does-the-sound-cut-off-when-both-people-speak-at-the-same-time-during-a-video-call-Skype-FaceTime-etc-yet-in-a-normal-phone-call-two-people-can-speak-at-the-same-time?share=1

z411 commented 1 year ago

Options to disable sound processing have already been merged into Element Web, just a heads up.

https://github.com/matrix-org/matrix-react-sdk/pull/8759

image