Sending a "quick reply" in a notification leads to clinging "unread" messages in the room

element-hq / element-android

A Matrix collaboration client for Android.

https://element.io/

GNU Affero General Public License v3.0

3.35k stars 713 forks source link

Sending a "quick reply" in a notification leads to clinging "unread" messages in the room #550

Open Ezwen opened 5 years ago

Ezwen commented 5 years ago

Each time I use the "quick reply" action from within a RiotX Android notification, the following happens:

my answer is sent successfully,
the corresponding room in RiotX shows an "unread message" (probably the message I answered to − maybe already at this point this is a bug),
if I open the room in RiotX, the "unread message" counter remains, as if opening (and scrolling through) the history in the said room does not manage to make the new message count as read − sometimes I kept unread counters on rooms for whole days,
only if I open the same room in Riot web, the message is finally registered as read, and the "unread message" counter disappears from the room in RiotX as well.

In other words, it seems there is a bug in tagging messages as read/unread when the quick reply action is used?

auscompgeek commented 5 years ago

It looks like the unread counter is of the previously notified messages, rather than the reply the user sent.

rajil commented 4 years ago

Can confirm the bug on Beta Riot 0.91.3 [400091032] (G-b3120).

532910 commented 4 years ago

Each time I use the "quick reply" action from within a RiotX Android notification, the following happens:

I see endless rotation animation

If I press this notification I got my message in a new notification:

532910 commented 4 years ago

I believe this issue must be riot-go-live, mustn't it?

T-bond commented 3 years ago

If I open the room, go back in history and scroll back to the newest message, the undread message indicator dissaperas correctly. (So no need for Element Web)

The other problems still apply, unfortunately (spinning indicator not vanishing, message won't get marked as read)

1.0.11 [40100110] (F-dffdcfe1)

immanuelfodor commented 3 years ago

I can confirm this, it's still an issue. Also reported in https://github.com/vector-im/element-android/issues/1139

immanuelfodor commented 3 years ago

This and the infinite quick reply spinner are the most annoying bugs of Element for me, experiencing it daily :(

chagai95 commented 1 year ago

I think replying implies also marking as read, maybe the original idea was to have them somehow separated? I doubt it, but I can't think of another reason. Maybe the idea of not clearing was to have the option to reply with multiple separate messages from these action buttons?

chagai95 commented 1 year ago

I tried playing around with it a bit now, I think this stuff is extremely difficult to debug, it seems like I keep on running into unrelated issues, the last issue I ran into is that on the dbg version the mark read does not work all together. so I'm just gonna try to release this commit as is and see if it's better like this, you're welcome to try it as well if you like and hopefully soon I can create a PR if I see it works.

chagai95 commented 1 year ago

I released my changes on this app on the Playstore if anyone wants to try them out, I think the behavior is now a bit better but not perfect, I'll be testing this in the next few weeks and if I'm happy I'll create a PR