element-hq / element-android

A Matrix collaboration client for Android.
https://element.io/
GNU Affero General Public License v3.0
3.36k stars 713 forks source link

Changing the screen orientation during video playback will cause the playback progress to be reset. #7995

Open YamatoRyou opened 1 year ago

YamatoRyou commented 1 year ago

Steps to reproduce

  1. Allow the system to automatically rotate the screen;
  2. Enter the conversation and click on a video to start playing it.

Outcome

What did you expect?

n/a

What happened instead?

If you rotate the screen during playback, the playback progress will be forcibly returned to the beginning of the video. And every time you rotate, the progress will be reset once.

Your phone model

HMD TA-1054; Mi 9T

Operating system version

Android 8.1; MIUI 12.5 by xiaomi.eu (based on Android 11)

Application version and app store

Element 1.5.20 (Google Play)

Homeserver

Synapse 1.75.0

Will you send logs?

No

Are you willing to provide a PR?

No

sgofferj commented 9 months ago

It doesn't only interrupt video playback. It interrupts audio playback, audio recording, taking photos, ...

@mnaturel I'd like to suggest an edit of the title to something like "Changing screen orientation interrupts several Element functions" as well as removing the minor, media and occasional tags. Especially the interruption and subsequent hanging of audio recording is almost a dealbreaker at least for me because you have to hold your phone perfectly still when recording an audio message, otherwise, the screen might rotate and your recording will be messed up.

mnaturel commented 9 months ago

It doesn't only interrupt video playback. It interrupts audio playback, audio recording, taking photos, ...

@mnaturel I'd like to suggest an edit of the title to something like "Changing screen orientation interrupts several Element functions" as well as removing the minor, media and occasional tags. Especially the interruption and subsequent hanging of audio recording is almost a dealbreaker at least for me because you have to hold your phone perfectly still when recording an audio message, otherwise, the screen might rotate and your recording will be messed up.

Hello @sgofferj, I have no longer access to the moderation of issues in this project. Maybe @manuroe or @bmarty you could take a look at the requested changes ?

manuroe commented 9 months ago

The title is fine. We can create another issue for audio recording and link it to this one. It looks like to be a full epic to manage every use case of media handling. Be aware the team is unlikely to actively work on it as we are fully busy on Element X. But this project is open source and contributions are still welcome.

sgofferj commented 9 months ago

The title is fine. We can create another issue for audio recording and link it to this one. It looks like to be a full epic to manage every use case of media handling. Be aware the team is unlikely to actively work on it as we are fully busy on Element X. But this project is open source and contributions are still welcome.

Öhm, if I remember right, Element X isn't even in public beta yet and you're not going to fix a bug that's critical to UX? I'd say, sending voice messages is much more popular than sending text messages nowadays and at least for me, having to re-record every second voice message I send because I didn't hold the phone perfectly still, is a clear deal breaker. There are other Matrix clients but in general public view Element = Matrix and Matrix = Element, so this kind of UX problem has the potential to ruin the whole ecosystem...