search

element-hq / element-android

A Matrix collaboration client for Android.
https://element.io/
GNU Affero General Public License v3.0
3.38k stars 725 forks source link

Reply quote is present when editing a message #8612

Open phorcys420 opened 1 year ago

phorcys420 commented 1 year ago

Steps to reproduce

  1. Open a chat
  2. (Send a message)
  3. Reply to a message
  4. Edit the reply
  5. See

Outcome

What did you expect?

I expected that the content that appears in the edit box would only be the reply text.

What happened instead?

The edit box also contained the "From" and original text (see video)

Your phone model

Google Pixel 6a

Operating system version

Android 13 (TQ3A.230705.001)

Application version and app store

Element 1.6.5 [40106052] (G-fd6a45a3), Rust SDK 0.6.0 (3fd55c0), Vodozemac 0.4.0 from Play Store

Homeserver

Synapse 1.85.2

Will you send logs?

No

Are you willing to provide a PR?

Yes

Palloxin commented 1 year ago

https://github.com/vector-im/element-android/assets/75091899/a025076c-a1cd-4884-9bc7-a2c243f04def

A video reproduction of the bug. Android 8

phorcys420 commented 1 year ago

I thought it was clear, but I did already include a video in my issue! In the "What happened?" section.

Palloxin commented 1 year ago

It says "Not found". Not sure if it is only me IMG_20230905_124032

pludi commented 1 year ago

Sounds like the same issue as in #8602

phorcys420 commented 1 year ago

It says "Not found". Not sure if it is only me

Oh yeah, you're right! Sorry.

Sounds like the same issue as in https://github.com/vector-im/element-android/issues/8602

I'm unsure given that #8602 only mentions text displaying issues.

pludi commented 1 year ago

Sounds like the same issue as in #8602

I'm unsure given that #8602 only mentions text displaying issues.

Below the first screenshots there's a section about "duplicate in reply to …:"

Luka5W commented 1 year ago

yep. its addressed in my issue and fixed in my pull request. its very annoying and has been there for a while (#8377) now. no idea how this commit could pass the QA. can't believe that no one has fixed this/ has noticed this behavior.

but features > stable app i guess :clown_face: and its only a major feature to edit replies/ markdown messages so... the label O-Uncommon and S-ToLeRaBlE is completely appropiate here :clown_face: :clown_face: :clown_face:

btw. i would think twice if you put any effort in this project... im not sure if i will if my pr isnt accepted without bigger change requests.