element-hq / element-android

A Matrix collaboration client for Android.
https://element.io/
Apache License 2.0
3.27k stars 677 forks source link

io.element.e2ee['force_disable'] not respected #8784

Open kashif-umair opened 3 months ago

kashif-umair commented 3 months ago

Steps to reproduce

The client well-known looks like this

{
  "io.element.e2ee": {
    "default": false,
    "force_disable": true
  },
  "m.homeserver": {
    "base_url": "https://chat.the-revivalists.org/"
  }
}

According to that, the client should forcefully disable any encryption related settings. It works perfectly on element web but the Android app doesn't respect this setting.

I believe the issue is around this code. I don't see anything related to forcefully disabling encryption: https://github.com/element-hq/element-android/blob/4231b32cc2324c7193c9cec54ffb4ed49004100c/vector/src/main/java/im/vector/app/features/roomdirectory/createroom/CreateRoomController.kt#L162-L178

Outcome

What did you expect?

The switch toggle should be disabled and it should not be possible to enable it.

What happened instead?

The switch toggle was active and I was able to enable the encryption while creating a room.

Your phone model

Realme X3 Superzoom

Operating system version

Android 12

Application version and app store

Element version 1.6.12, from Google Play

Homeserver

Synapse 1.102.0

Will you send logs?

Yes

Are you willing to provide a PR?

No