the first one (5cd78c02aacb697f2cfe19fead1b29a4e22d9f95) ensure that the keys displayed on screen are refresh as fast as possible after a reset key. Previously the user had to wait for the next sync response to see the displayed key change in this screen:
To reproduce, on this screen ^ click on "Reset Keys" and observe that as soon as the loading dialog is dimissed, the keys are updated on screen. Previously user had to wait at most 30s to see the update.
The second fix (1155c43fe07c10e46e3e187b40b028bff30e04aa) ensures that when the BootstrapReAuthFragment is displayed, a first submit request is performed. Else an infinite loading wheel was displayed.
To reproduce the issue:
create a new account on EA by selecting matrix.org (or another HS)
when the account is created and the welcome screen is displayed (with action to personalize the account, and a "take me home button"), kill the app (do not go on the home screen for the moment).
start the application again, a dialog "Encryption upgrade available" is displayed, if you click on it, a bottom sheet is opened with an infinite loading wheel.
With this PR, the infinite loading wheel is not displayed, and if necessary, the ReAuthActivity is launch, to either ask the user to enter their password or login again using SSO
I have tested OK the direct flow (i.e. without entering the password) and the flow with entering the password. To test this flow you have to wait for the grace period server side to expire (not sure what the grace period duration is on matrix.org).
Motivation and context
Fix infinite loading wheel.
Screenshots / GIFs
Tests
See content above.
Tested devices
[ ] Physical
[x] Emulator
OS version(s):
Checklist
[ ] Changes has been tested on an Android device or Android emulator with API 21
[ ] UI change has been tested on both light and dark themes
Type of change
Content
This PR contains 2 fixes:
To reproduce, on this screen ^ click on "Reset Keys" and observe that as soon as the loading dialog is dimissed, the keys are updated on screen. Previously user had to wait at most 30s to see the update.
BootstrapReAuthFragmentis displayed, a first submit request is performed. Else an infinite loading wheel was displayed.To reproduce the issue:
With this PR, the infinite loading wheel is not displayed, and if necessary, the
ReAuthActivityis launch, to either ask the user to enter their password or login again using SSOI have tested OK the direct flow (i.e. without entering the password) and the flow with entering the password. To test this flow you have to wait for the grace period server side to expire (not sure what the grace period duration is on matrix.org).
Motivation and context
Fix infinite loading wheel.
Screenshots / GIFs
Tests
Tested devices
Checklist