element-hq / element-android

A Matrix collaboration client for Android.
https://element.io/
GNU Affero General Public License v3.0
3.34k stars 709 forks source link

Images Posted from RiotX Incorrectly Displayed in Desktop Client #978

Open cgarwood82 opened 4 years ago

cgarwood82 commented 4 years ago

Sharing images from riotx display perfectly fine in the riotx client but when displayed from the desktop client, the images are distorted and displayed in landscape. Not sure if this is a riotx or riot-web issue.

Here is a screenshot of riotx on my phone displaying images as expected: https://i.postimg.cc/XXMkzZ6X/Screenshot-20200210-104808-Riot-X.jpg

Here is a screenshot of the desktop riot client displayed the images, though distorted and not rotated: https://i.postimg.cc/sDXzjvWb/riot-web.png

RiotX Version: 0.13.0-dev Riot Web|Desktop: 1.5.8-1

I'll provide whatever else is needed if requested.

cgarwood82 commented 4 years ago

View Source output of decrypted, distorted image from Riot-web Client:

{
  "content": {
    "body": "20200210_100027.jpg",
    "file": {
      "hashes": {
        "sha256": "weLhf1KL8CyliEFCq9/NV3rL97Gp9wRVtRsMzQn7WtU"
      },
      "iv": "1SJifEV9kPoAAAAAAAAAAA",
      "key": {
        "alg": "A256CTR",
        "ext": true,
        "k": "wYCOyoTUaEb7ksNd_l17NFlAOVh_z90_fZYJcQx7wyM",
        "key_ops": [
          "encrypt",
          "decrypt"
        ],
        "kty": "oct"
      },
      "mimetype": "image/jpeg",
      "url": "REDACTED",
      "v": "v2"
    },
    "info": {
      "h": 4032,
      "mimetype": "image/jpeg",
      "size": 2646385,
      "w": 3024
    },
    "msgtype": "m.image"
  },
  "room_id": "REDACTED",
  "type": "m.room.message"
}

Viewing same decrypted source from RiotX:

{
    "content": {
        "body": "20200210_100027.jpg",
        "file": {
            "hashes": {
                "sha256": "weLhf1KL8CyliEFCq9\/NV3rL97Gp9wRVtRsMzQn7WtU"
            },
            "iv": "1SJifEV9kPoAAAAAAAAAAA",
            "key": {
                "alg": "A256CTR",
                "ext": true,
                "k": "wYCOyoTUaEb7ksNd_l17NFlAOVh_z90_fZYJcQx7wyM",
                "key_ops": [
                    "encrypt",
                    "decrypt"
                ],
                "kty": "oct"
            },
            "mimetype": "image\/jpeg",
            "url": "REDACTED",
            "v": "v2"
        },
        "info": {
            "h": 4032,
            "mimetype": "image\/jpeg",
            "size": 2646385,
            "w": 3024
        },
        "msgtype": "m.image"
    },
    "room_id": "REDACTED",
    "type": "m.room.message"
}

Perhaps this is related to https://github.com/vector-im/riotX-android/issues/363 ?

bmarty commented 4 years ago

It seems that Riot-Web does not care about orientation of image store in EXIF data, according to @onurays

bwindels commented 4 years ago

See https://github.com/vector-im/riot-web/issues/1999