search

element-hq / element-call

Group calls powered by Matrix
https://call.element.io
GNU Affero General Public License v3.0
574 stars 89 forks source link

Build steps do not create working dist output #1867

Closed socceroos closed 11 months ago

socceroos commented 11 months ago

Steps to reproduce

  1. Clone repository
  2. Move into repo directory
  3. Run yarn and yarn build
  4. Fix matrix.org/olm resolve issue by downloading olm manually and changing package.json to point to local file.
  5. Rerun yarn and yarn build

Outcome

What did you expect?

I expected that in the dist folder would be a working build of element-call.

What happened instead?

The build completes, but there is no dist/assets folder in the output. The output is essentially useless.

Operating system

Ubuntu

Browser information

No response

URL for webapp

No response

Will you send logs?

No

socceroos commented 11 months ago

yarn version: 3.5.1 vite version: 4.5.0

yarn output:

➤ YN0000: ┌ Resolution step
➤ YN0002: │ @opentelemetry/context-zone@npm:1.15.2 doesn't provide @opentelemetry/api (pfada8), requested by @opentelemetry/context-zone-peer-dep
➤ YN0002: │ root-workspace-0b6124@workspace:. doesn't provide @babel/eslint-parser (p0ee87), requested by eslint-plugin-matrix-org
➤ YN0002: │ root-workspace-0b6124@workspace:. doesn't provide @babel/eslint-plugin (p2ae7a), requested by eslint-plugin-matrix-org
➤ YN0002: │ root-workspace-0b6124@workspace:. doesn't provide @fontsource/inconsolata (p1cc27), requested by @vector-im/compound-web
➤ YN0002: │ root-workspace-0b6124@workspace:. doesn't provide @fontsource/inter (p264cc), requested by @vector-im/compound-web
➤ YN0002: │ root-workspace-0b6124@workspace:. doesn't provide @testing-library/dom (p59b22), requested by @testing-library/user-event
➤ YN0002: │ root-workspace-0b6124@workspace:. doesn't provide eslint-plugin-jest (p88453), requested by eslint-plugin-matrix-org
➤ YN0002: │ root-workspace-0b6124@workspace:. doesn't provide postcss (pc50e6), requested by postcss-preset-env
➤ YN0002: │ root-workspace-0b6124@workspace:. doesn't provide webpack (p0676c), requested by babel-loader
➤ YN0002: │ root-workspace-0b6124@workspace:. doesn't provide zone.js (p128b6), requested by @opentelemetry/instrumentation-user-interaction
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed in 1s 523ms
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed in 1s 529ms
➤ YN0000: ┌ Link step
➤ YN0000: └ Completed in 1s 715ms
➤ YN0000: Done with warnings in 5s 67ms

yarn build output:

vite v4.5.0 building for production...
transforming (297) node_modules/@sentry/core/esm/tracing/hubextensions.js[vite:css] start value has mixed support, consider using flex-start instead
19 |     the emoji picker, these are: 20e3, 23cf, 24c2, 25a0-25c1, 2665, 2764, 2b06, 2b1c.
20 |     Therefore we define a unicode-range to load which excludes the glyphs
21 |     (to avoid having to maintain a fork of Inter). */
   |     ^
22 |  
23 |  @import "normalize.css/normalize.css";
[vite:css] start value has mixed support, consider using flex-start instead
21 |     (to avoid having to maintain a fork of Inter). */
22 |  
23 |  @import "normalize.css/normalize.css";
   |    ^
24 |  @import "@vector-im/compound-design-tokens/assets/web/css/compound-design-tokens.css";
25 |  @import "@vector-im/compound-web/dist/style.css";
[plugin:vite:resolve] Module "crypto" has been externalized for browser compatibility, imported by "/usr/local/element-call/node_modules/@matrix-org/olm/olm.js". See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] Module "path" has been externalized for browser compatibility, imported by "/usr/local/element-call/node_modules/@matrix-org/olm/olm.js". See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] Module "fs" has been externalized for browser compatibility, imported by "/usr/local/element-call/node_modules/@matrix-org/olm/olm.js". See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
✓ 1495 modules transformed.

dist directory:

dist
dist/.well-known
dist/locales
dist/locales/zh-Hant
dist/locales/bg
dist/locales/fa
dist/locales/en-GB
dist/locales/de
dist/locales/pl
dist/locales/es
dist/locales/ru
dist/locales/el
dist/locales/sk
dist/locales/fr
dist/locales/et
dist/locales/it
dist/locales/zh-Hans
dist/locales/tr
dist/locales/id
dist/locales/vi
dist/locales/sv
dist/locales/ko
dist/locales/uk
dist/locales/lv
dist/locales/ja
dist/locales/cs
dist/fonts
dist/fonts/Inter
socceroos commented 11 months ago

Solved.

Thanks to Dave for his suggestion to run Yarn 1.x. Downgrading yarn and re-running yarn and yarn build uncovered the source of the problem: error 137 (out of RAM).

I then compiled element-call on another machine with more headroom and it produced the desired output.