element-hq / element-call

Group calls powered by Matrix
https://call.element.io
GNU Affero General Public License v3.0
589 stars 90 forks source link

Participant count is incorrect #1998

Open toger5 opened 11 months ago

toger5 commented 11 months ago

The participant counter on the top left corner of element call is incorrect.

The age is only properly set right after the evnt is fetched from the HS. We suspect, this collides with the idea of the sync cache from the js-sdk.

It should only store events with the localTimestamp and not the unsigned.age.

toger5 commented 11 months ago

Alternative

The age propery is not fully implement and caused other issues already. age also makes unsigned mutable. So it is important to know when the event was fetched to interpret the unsigned data correctly. It was discussed if instead of an unsigned.age we introduce a enporint to the hs to get_origin_server_now which can be used to compute the offset of the local timestamp and the origin server one. Then the origin_server_ts can be used as an alternative to age.

fkwp commented 10 months ago

maybe https://github.com/matrix-org/matrix-spec-proposals/pull/4018 is a proper fix for this issue

Half-Shot commented 6 months ago

https://github.com/matrix-org/matrix-video-chat-rageshakes/issues/5933 is a rageshake for this