search

element-hq / element-call

Group calls powered by Matrix
https://call.element.io
Apache License 2.0
554 stars 88 forks source link

Reword message for failure to join/find room #2360

Closed AndrewFerr closed 3 months ago

AndrewFerr commented 4 months ago

The message originally focused on the old feature of being able to create a room with a custom URL. Instead, be more direct & say that the current URL is for an inaccessible room.

This new message is based on what Element Web says for this scenario.

AndrewFerr commented 4 months ago

Partially addresses #2348. The issue of a knock button sometimes appearing for private rooms is likely caused by a stale room membership cache, and won't be addressed by this PR.

AndrewFerr commented 4 months ago

Also note that the condition for showing this message is an error response in getting the room summary, which returns 40x for both private & non-existent rooms.