search

element-hq / element-call

Group calls powered by Matrix
https://call.element.io
GNU Affero General Public License v3.0
561 stars 90 forks source link

New spotlight layout #2382

Closed robintown closed 2 months ago

robintown commented 4 months ago

Based on https://github.com/element-hq/element-call/pull/2381

Closes https://github.com/element-hq/element-call/issues/2219 Closes https://github.com/element-hq/element-call/issues/1215

robintown commented 4 months ago

Not yet quite ready to review yet. I think I'd like to add some more comments before I consider this ready.

hanthor commented 2 months ago

I think I just tested this out on cell.element.dev. It doesn't seems to be giving the spotlight position to unmuted, talking participants. This is what I did:

  1. start the call from my laptop at call.element.dev
  2. send the invite link to myself
  3. join on 2 different android phones
  4. mute on all devices
  5. my computer's video is in the spotlight and has had it the whole time
  6. unmute and start talking on my phone
  7. the spotlight does not change, but the other participant get highlighted