element-hq / element-call

Group calls powered by Matrix
https://call.element.io
GNU Affero General Public License v3.0
561 stars 90 forks source link

Show speaker in the spotlight in large grids #2416

Closed robintown closed 2 months ago

robintown commented 3 months ago

Based on https://github.com/element-hq/element-call/pull/2382

robintown commented 2 months ago

I think I do have an argument against basing the decision on whether there is a scroll bar:

However I totally get the desire to not use an arbitrary number. Basing the decision on whether there is a scroll bar would be pretty non-trivial, and this part of the designs is still subject to change (we want to workshop it further), so: I suggest that the scroll bar method is not worth the time investment at this stage, regardless of whether my argument above makes sense.

toger5 commented 2 months ago

I suggest that the scroll bar method is not worth the time investment at this stage, regardless of whether my argument above makes sense.

I get behind this! I was mostly thinking that the reason for this is to always have the speaker visible. With more ppl (or a scroll container) there is the chance (independent of the user being at the bottom or the top) to not see a user so it makes sense to at least make sure the speaker is visible.

But I like going with this first and making a decision that requires a lot of dev effort based on more usage experience!