element-hq / element-call

Group calls powered by Matrix
https://call.element.io
Apache License 2.0
535 stars 84 forks source link

Broken base64 encoding for URL password parameter (shared secret) for SPA calls #2429

Closed fkwp closed 2 weeks ago

robintown commented 2 weeks ago

Figured out what's happening: when converting to URL-safe base64 we're calling String.replace instead of String.replaceAll, which replaces only the first instance of + or / in the key.