1.11.54 fails to build on windows

[fidoman]

Steps to reproduce

electron-builder.js that appears in root folder of this version breaks build process on Windows Windows tries to run it with JScript engine

Cite from docs: https://www.electron.build/configuration/configuration.html Tip

If you want to use js file, do not name it electron-builder.js. It will conflict with electron-builder package name.

Outcome

Microsoft JScript error in electron-builder.js line:1 char:1

Operating system

Windows

Application version

1.11.54

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

[t3chguy]

It works fine in CI, contributions welcome but otherwise it likely won't be touched until https://github.com/electron-userland/electron-builder/issues/7775 allows us to use TS.

[globi84]

same issue here with version 1.11.57. if I rename the electron-builder.js file something will be compiled without errors, but I can't start the exe afterwards.

[fidoman]

windows build is DEAD

git pull Updating 18c4c9d..58fd8b2 Fast-forward .github/workflows/build_and_deploy.yaml | 18 +- .github/workflows/build_macos.yaml | 8 +- .github/workflows/build_windows.yaml | 5 + .github/workflows/release-drafter.yml | 18 +- .github/workflows/release.yml | 14 ++ CHANGELOG.md | 34 +++ dockerbuild/Dockerfile | 6 +- docs/packaging.md | 7 +- package.json | 8 +- src/tray.ts | 4 +- yarn.lock | 358 +++++++++++++++++--------------- 11 files changed, 268 insertions(+), 212 deletions(-)

git status On branch develop Your branch is up to date with 'origin/develop'.

yarn install yarn install v1.22.21 warning ....\package.json: No license field [1/5] Validating package.json... [2/5] Resolving packages... warning Resolution field "@types/node@18.19.8" is incompatible with requested version "@types/node@^17.0.36" [3/5] Fetching packages... warning smol-toml@1.1.3: The engine "pnpm" appears to be invalid. [4/5] Linking dependencies... warning " > eslint-plugin-matrix-org@1.2.1" has unmet peer dependency "@babel/eslint-parser@". warning " > eslint-plugin-matrix-org@1.2.1" has unmet peer dependency "@babel/eslint-plugin@". warning " > eslint-plugin-matrix-org@1.2.1" has unmet peer dependency "eslint-plugin-deprecate@". warning " > eslint-plugin-matrix-org@1.2.1" has unmet peer dependency "eslint-plugin-jest@". warning " > eslint-plugin-matrix-org@1.2.1" has unmet peer dependency "eslint-plugin-jsx-a11y@". warning " > eslint-plugin-matrix-org@1.2.1" has unmet peer dependency "eslint-plugin-react@". warning " > eslint-plugin-matrix-org@1.2.1" has unmet peer dependency "eslint-plugin-react-hooks@*". [5/5] Building fresh packages... Done in 51.94s.

yarn run fetch --noverify --cfgdir "" yarn run v1.22.21 warning ....\package.json: No license field $ yarn run mkdirs && ts-node scripts/fetch-package.ts --noverify --cfgdir "" warning ....\package.json: No license field $ mkdirp packages deploys Downloading https://github.com/element-hq/element-web/releases/download/v1.11.57/element-v1.11.57.tar.gz... packages\element-v1.11.57.tar.gz downloaded but NOT verified webapp.asar already present: removing Skipping config file Pack deploys\element-v1.11.57 -> webapp.asar Done! Done in 22.48s.

yarn run build

[fidoman]

documentation asks not to use this name for config

commit 6617b29028ab1ff3883323693cc3f64a850be2f3 Author: Michael Telatynski 7t3chguy@gmail.com Date: Wed Jan 3 16:29:48 2024 +0000

Move electron-builder config to javascript file (#1402)

diff --git a/electron-builder.js b/electron-builder.js new file mode 100644 index 0000000..1edef2b --- /dev/null +++ b/electron-builder.js

[fidoman]

[globi84]

It works fine in CI, contributions welcome but otherwise it likely won't be touched until electron-userland/electron-builder#7775 allows us to use TS.

no it do not work fine. it is still broken at 1.11.59. please fix it. there is over one month brocken and no one cares.

[t3chguy]

in CI

https://github.com/element-hq/element-desktop/actions/runs/8065409927/job/22031183997#step:17:58

[globi84]

sorry and how can i build it with my own config from your ci? there is no manual on your readme

[t3chguy]

You can inspect the CI workflow - its in the repository - https://github.com/element-hq/element-desktop/blob/develop/.github/workflows/build_windows.yaml