element-hq / element-desktop

A glossy Matrix collaboration client for desktop.
https://element.io
GNU Affero General Public License v3.0
1.13k stars 258 forks source link

Some pictures are lost when exporting chat #1812

Open blastrock opened 1 month ago

blastrock commented 1 month ago

Steps to reproduce

  1. Post a lot of picture all at once in a chat
  2. Export the chat

Outcome

What did you expect?

The export should contain all the pictures

What happened instead?

Images are named with a date-time, like image-7-30-2024 at 4-22-57 PM.jpg. So if two images are posted within the same second, only the first one will be saved. This happened to me when a friend posted a lot of photos on WhatsApp, all the messages were received in the same second.

Operating system

Linux

Application version

Element version: 1.11.72 Crypto version: Rust SDK 0.7.1 (431263d), Vodozemac 0.6.0

How did you install the app?

Flatpak

Homeserver

https://hub.docker.com/layers/matrixdotorg/synapse/sha256-492e0561429a422fe69c2ee82a00ff7654bdb85524f3b59a8bf26caad76d2e31.sig/images/sha256-6770481163ac09614c842fef9178236a89b8b2adb71734aaa6da4ebadfe60454?context=explore

Will you send logs?

No

dbkr commented 1 month ago

Marking this a good first issue as it should be fairly straightforward to just append (1), (2) etc to images whose name would end up the same... that or just a few random characters.