search

element-hq / element-desktop

A glossy Matrix collaboration client for desktop.
https://element.io
GNU Affero General Public License v3.0
1.15k stars 261 forks source link

Element choses same colour for both me and the other person I'm talking to #1894

Closed mohmad-null closed 3 weeks ago

mohmad-null commented 3 weeks ago

Steps to reproduce

Element has randomly assigned me a colour and randomly assigned me friend a colour for our usernames. They problem is, both of us have been assigned the /same/ colour. There are only the two of us, so it's not like Element ran out of colours to choose from.

I expect someone colourblind would also appreciate being able to specify colours, so there's an accessibility aspect to this too.

I see this: https://github.com/element-hq/element-meta/issues/841 - but there's no open issue and as this is a usability and accessibility bug, hope it's ok that I file it as an issue.

Outcome

What did you expect?

Either random different colours, or ideally, that and the ability to specify the colour

What happened instead?

Got the same colour as my correspondent; unable to change either.

Operating system

windows

Application version

desktop Element version: 1.11.76

How did you install the app?

element.io

Homeserver

matrix

Will you send logs?

No

t3chguy commented 3 weeks ago

Duplicate of https://github.com/element-hq/element-meta/discussions/842

mohmad-null commented 3 weeks ago

Sorry, but I have to disagree, this is a bug, and different from https://github.com/element-hq/element-meta/discussions/842. You can work around the bug with that (which there seems to be weird resistence to implementing) - however the bug is that element is assigning other users the same colour it's assigning me. That defeats the entire point of having colours in the first place.

t3chguy commented 3 weeks ago

The colours are not room-specific. They are specific to the user across all rooms by design. They are based on a hash of the MXID mapped to a small palette of colours. Given that, the only way around it is to make the colours user-choosable.

mohmad-null commented 3 weeks ago

Further: https://github.com/element-hq/element-meta/discussions/842 is about choosing your colour for OTHER users. This bug is entirely about choosing colours ON YOUR OWN MACHINE. I don't care what colour I appear to other users, I care what colour users (and myself) appear on my machine; the inability to do so is a core missing accessiblity UI feature. So yes, this absolutely is NOT a duplicate of 842

mohmad-null commented 3 weeks ago

The colours are not room-specific. They are specific to the user across all rooms by design. They are based on a hash of the MXID mapped to a small palette of colours. Given that, the only way around it is to make the colours user-choosable.

I don't understand this from a technical perspective, but to me it sounds like a design flaw as relates to this bug.