search

element-hq / element-integration-manager

Element Integration Manager related issues
6 stars 1 forks source link

[Feeds] Adding bot and migration not working properly #45

Closed natrius closed 5 months ago

natrius commented 1 year ago

Describe the bug I'm admin in some rooms and when trying to migrate according to https://ems-docs.element.io/books/element-cloud-documentation/page/migrate-to-the-new-github-and-feeds-bots i klick on feeds and on "Add" then the only thing thats happening is, the Mod gets promoted natrius changed the power level of @feeds:integrations.ems.host from Default to Moderator. and i get a message Something went wrong. Failed to add this extension to the room: You need to be able to invite users to do that. (I'm admin...) and i'm stuck there-

At random i am able to get further and the bot gets invited (just able to it in one room, the second room i'm trying to migrate its stuck) and it times out and after that i was not able to see a "migrate" button or anything and i have to search what i used to set up that bot.

Expected behavior Well, not timing out all the time so i can try it :)

Screenshots First click on "Add" grafik After that in the chat (why mod? O.o) grafik And repeat.

Desktop (please complete the following information):

natrius commented 1 year ago

By sheer luck i managed to get further in another room but immediately stuck with another message grafik

Afterwards i was able to migrate in that room. After that i got back to the room i mentioned in the first posting and it worked there as well. So it needs some minutes between each step, some retrying and then it might work.

awdrfunk commented 1 year ago

have exactly the same error

Something went wrong Failed to add this extension to the room: Du musst die Berechtigung "Benutzer einladen" haben, um diese Aktion ausführen zu können.

erebion commented 1 year ago

Can confirm, just wanted to report this.

vranki commented 1 year ago

Happens to me also. Another error I'm seeing (in bottom part of the bot config UI): "503 Service Temporarily Unavailable".

erebion commented 1 year ago

I need to migrate around two dozen rooms. I've noticed that it works sometimes, then I'm able to add the bot to one or two rooms and then it stops working again for a while.

MarkWieczorek commented 1 year ago

Same problem. This works for some rooms, but not for most. With dozens of rooms to update, the migration is highly non-optimal.

Half-Shot commented 1 year ago

Hi folks. So I can see a few classes of failures here:

Please keep reporting issues as you find them and we'll keep looking.

natrius commented 1 year ago

Thanks for the answer! Sounds correct, to add: Point1 it seems like it does not join at all after the initial fail (no permission). It may be that point 2 leads to point 1 as well.

razzeee commented 1 year ago

My bot seems to have joined and has been elevated, but I only get this message, which isn't helpful

image

Half-Shot commented 1 year ago

@razzeee Can you give me a RoomID that you tried to bridge to, I'll track down the error.

razzeee commented 1 year ago

@Half-Shot !zDwUBYVNEXEzSbTYwI:matrix.org

awdrfunk commented 1 year ago

with me it is still the same

Something went wrong Failed to add this extension to the room: Du musst die Berechtigung "Benutzer einladen" haben, um diese Aktion ausführen zu können.

natrius commented 1 year ago

Take your time. After the intial "no permissions" wait a bit and try it occasionally again. Then you will see the bot "feed" joining, its probbaly not working on the spot as well, again, come back a bit later and simply try again. Annoying, but it works.

awdrfunk commented 1 year ago

Take your time. After the intial "no permissions" wait a bit and try it occasionally again. Then you will see the bot "feed" joining, its probbaly not working on the spot as well, again, come back a bit later and simply try again. Annoying, but it works.

unfortunately no, I try it for 1-2 days regularly again and again, without results, this is extremely annoying

MarkWieczorek commented 1 year ago

For me, I have two admins in the room. One successfully added the new bot, bot the pre-existing subscription isn't listed. When the other admin tries to open the bot integration, they get the error "error Failed to fetch existing connections: User is not joined to the room."

room id: !leKewkNLGCqpFqcBds:matrix.org

awdrfunk commented 1 year ago

i think it would be better if the whole thing would work correctly, especially rss-bot and github-bot, before luring more users to their doom. i've been trying to integrate the rss-bot for two days and it still doesn't work :-(

ima_ae55954

awdrfunk commented 1 year ago

since 2 days and certainly 50 attempts the same error

Unbenannt Unbenannt2

awdrfunk commented 1 year ago

it is very frustrating, now already 4 days passed without the rss-bot (and also github-bot) working. there is the note "Please keep reporting issues as you find them and we'll keep looking." not very helpful when you seem to be unable to fix basic functionality within a reasonable time.

erebion commented 1 year ago

within a reasonable time.

I think even a week after a launch is still a reasonable time for going through GitHub issues where people spam and then try to figure out what is going wrong.

awdrfunk commented 1 year ago

spam 😀 when you follow up because you don't get any reasonable, goal-oriented answers? that's imho exactly the (wrong) reaction, attitude and bad communication of today's working world, asking questions, complaining forbidden, eat or die! and does the answer mean that ifs not reported via github, then faster and more efficient? 😀 thanks, i'm too old for such unqualified, thin-hatted reactions and error-management, my time is too waste for that, that's it.

Half-Shot commented 1 year ago

We're still looking into it, broadly it looks like the (federated) user @\feeds:integrations.ems.host is failing to join some rooms. We've been quietly working on it, and in most cases I have found it will join after a few attempts. Using the /rageshake command in Element is helpful for us to track it down, because it gives us useful logs. Please link to this issue when doing so if you can.

Unfortunately while we can reproduce the intermittent failure, the continuous failures could be a few things. Again, unfortunately mass testing is the only way you'll find some of these bugs.

(Apologies to @f33ds who I pinged because our user identifier format hates GitHub users)

razzeee commented 1 year ago

For what it's worth, github started to work for me, but it's not on par with the old implementation it seems see https://github.com/vector-im/element-integration-manager/issues/60

The RSS room also started to work, thanks @Half-Shot

NineBAR commented 5 months ago

Yeah -- I'm running into this exact issue. I administer my own homeserver. I've looked high and low for documentation about the necessary parameters for the room, and tried just about all variations of access. Sometimes it'll tell me I can't add a user (though it does successfully make @feeds:integrations.ems.host a moderator). Sometimes it just fails without explanation.

NineBAR commented 5 months ago

Yeah -- I'm running into this exact issue. I administer my own homeserver. I've looked high and low for documentation about the necessary parameters for the room, and tried just about all variations of access. Sometimes it'll tell me I can't add a user (though it does successfully make @feeds:integrations.ems.host a moderator). Sometimes it just fails without explanation.

Magically fixed in the element update that rolled out today.

natrius commented 5 months ago

From my side this is solved as the last times i added the feed-bot it worked like at charm! :)