element-hq / element-integration-manager

Element Integration Manager related issues
6 stars 1 forks source link

Scalar integs that try to open new windows fail on Electron #88

Closed dbkr closed 1 year ago

dbkr commented 5 years ago

Some Scalar integs (eg. Slack bridging) try to window.open to do OAuth. This is slightly broken in the Electron app because we intercept window.open and open the URL in the user's browser. You can still auth, and if you make the integration try again, it will work, but the you get a message telling you to enable popups and you have to manually get it to re-poll.

Half-Shot commented 1 year ago

Believe the Slack widget thing was entirely my fault and the only place we ever did this. We no longer use the scalar-web widgets so this can be closed.