element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 498 forks source link

No calls button #2472

Open ionwerz opened 5 years ago

ionwerz commented 5 years ago

There is no Call button icon on iPhone X after starting E2E chat

ghost commented 5 years ago

I have this same issue, I create a room, enable e2e and then the call button is gone on my iPhone XR but on my Pixel 3XL it Is still there and I can call on my pixel and my iPhone shows the incoming call etc but I can't call on my iPhone because there's no icon. It happens very randomly but is pretty easy to replicate.

cwmke commented 5 years ago

I had the same issue and resolved it by going to settings and clearing the cache. When I went back to the conversation the button reappeared.

ashechka commented 5 years ago

Same problem to me. Can it be issue with OS version, bcz on my XR(12.4.3) On my Ipad with OS ver9.3.5 RIOT app with my personal homeserver working stable

ashechka commented 5 years ago

after upgrade to latest version - first 4-5 attempts to call i am able to see buttons and dial window appears. but connection was not established. After a while this button disappear again without any reason

ghost commented 4 years ago

I noticed that this bug, for me, comes from the MXRoomSummary reporting that there's only 1 member joined hence not making this button visible, even though there are 2 joined members in the room. I fixed it with this workaround in RoomViewController::refreshRoomInputToolbar

        // Workaround fix to keep the members count of the room state updated
        MXRoomState *roomState = self.roomDataSource.roomState;
        MXRoom *room = self.roomDataSource.room;
        MXRoomMembers *members = roomState.members;
        MXRoomMembersCount *membersCount = roomState.membersCount;
        if ([members handleStateEvents:roomState.stateEvents])
        {
            // Update counters for currently known room members
            membersCount.members = members.members.count;
            membersCount.joined = members.joinedMembers.count;
            membersCount.invited =  [members membersWithMembership:MXMembershipInvite].count;
        }
        [self.mainSession.roomSummaryUpdateDelegate session:self.mainSession updateRoomSummary:room.summary withStateEvents:roomState.stateEvents roomState:roomState];

        // Check whether the call option is supported
        roomInputToolbarView.supportCallOption = self.roomDataSource.mxSession.callManager && self.roomDataSource.room.summary.membersCount.joined >= 2;
shuheng-liu commented 4 years ago

Same issue on iPad Pro 12.9". I don't have the phone call button in E2EE chat. However, I can pick up phone calls made by other people (using other devices). The button does appear on iPhone XS Max. I suspect whoever fixed the issue forgot to test the iPad OS version. Could anyone please consider fixing it in the next update? VoIP is a very important feature of the matrix protocol and it'd be a shame if iPads can only pick up phone calls instead of making them. Thanks.

shuheng-liu commented 4 years ago

Here are screenshots of the iPad vs iPhone App. The phone call button is missing for the iPad.

iPad App

251588438605_ pic

iPhone App

241588438498_ pic

jpggithub commented 4 years ago

Phone call button missing for an E2E on iphone v11.4.1 with Riot 0.11.4 (olm v3.1.0). Going in settings and clearing the cache fix the problem (see above https://github.com/vector-im/riot-ios/issues/2472#issuecomment-515648568)

rozahp commented 3 years ago

I use iPhone 6 with latest iOS upgrade. I am an admin on my homeserver and when joining group rooms there is no call button. Video button is there.

On element-web (Firefox) and Android (Galaxy) this is not an issue.

Call button is found when chatting 1o1, private rooms. And I can receive calls from group rooms.