Use new PHPicker on iOS 14 for Photo selection

element-hq / element-ios

A glossy Matrix collaboration client for iOS

https://element.io

Apache License 2.0

1.72k stars 480 forks source link

Use new PHPicker on iOS 14 for Photo selection #3378

Open aaronraimist opened 4 years ago

aaronraimist commented 4 years ago

Seems extremely cool

Doesn't require photos library access
Has build in multi select and search
Is probably much more performant than the current solution which is very slow for me with tens of thousands of photos
UIImagePickerController is now deprecated

https://developer.apple.com/videos/play/wwdc2020/10652/

pixlwave commented 2 years ago

Adding a comment to this issue to emphasise that it fixes the problem (such as #5327) where the user chose "Selected Photos" instead of "All Photos" and only sees a limited selection of their images to send.

pixlwave commented 2 years ago

There's a basic initial implementation of the new picker in MediaPickerPresenter used for FTUE. It still needs support for videos and multiple selection before we can use it everywhere. It could be used in SingleImagePickerPresenter as is.

br4yd commented 1 year ago

Is there an update on this issue? This would make it easier to select multiple images, too. Currently you have to know how to select multiple images because per default it only selects one. I don't think many users figure out "by accident", that you have to open the current photo picker, open a library folder like "recents", then in addition click on "choose" and then be able to select multiple images. (At least I haven't found this for months)

cloudaxes commented 9 months ago

+1, this would be a good quality-of-life improvement.