search

element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 492 forks source link

Signing up on iOS causes Synapse to send you matrix-branded confirmation mail rather than element-branded #3457

Open ara4n opened 4 years ago

ara4n commented 4 years ago

We seem to be losing the brand param somewhere along the way.

clokep commented 4 years ago

It does not look like the verification e-mails sent from Synapse have any branding on them.

For comparison, see the email notification email which have various branding based on the "app_name". (The app name can be set via the brand parameter being set in the data parameter sent to the pusher endpoints or a few other places.)

It does seem that branding in Sydent got updated, but I do not believe that is used on matrix.org.

ismailgulek commented 4 years ago

I'm trying to figure out client actions for this. Btw i couldn't see any app_name at email notification.

So @clokep if there is not a plan to have branding on verification e-mails, then i'll close the issue.

clokep commented 4 years ago

I'm trying to figure out client actions for this. Btw i couldn't see any app_name at email notification.

Sorry, I had linked to the wrong spot, it should be https://github.com/matrix-org/synapse/blob/release-v1.19.0/synapse/res/templates/notif_mail.html (I've updated the above comment also).

So @clokep if there is not a plan to have branding on verification e-mails, then i'll close the issue.

I don't believe there is, but we might be able to do that if necessary.

ismailgulek commented 4 years ago

@ara4n looks like we didn't have any branding on verification mails. Do you want it to be implemented?