search

element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 495 forks source link

Edits are not always visible #4329

Open jaywink opened 3 years ago

jaywink commented 3 years ago

Filing on behalf of another user. This relates to a similar Element Android issue here: https://github.com/vector-im/element-android/issues/3336

Describe the bug

User cannot see some edits. For a linked rageshake, the user cannot see a message they edited themselves on the iOS device earlier. On web the edits display fine. This has been a consistent problem for the user for some time in what seems like being an issue especially in larger encrypted rooms. This particular room has 533 members.

Screenshots and message details in rageshakes due to being a private room.

Steps to reproduce

  1. Edit a message in a room, or observe another user's edited message
  2. Reinstall the app to sync only data from the server
  3. Find previously edited message
  4. Result: Only the message before the edit is shown
Anderas commented 2 years ago

There are / were three unrelated reasons why edits do not show on iOS:

  1. Edited message is sometimes not decrypted and thus not shown https://github.com/vector-im/element-ios/issues/5835
  2. Edited message is not updated in the timeline enumerator https://github.com/vector-im/element-ios/issues/5848
  3. Clean install will load message history without edits (this ticket)

Whilst the first two have now been fixed, the last one requires a backend solution (at least for encrypted rooms) and / or client-side aggregation of edits on initial sync, see related discussion on MSC.

With two of the three causes resolved I am reducing the severity of this issue.