search

element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
Apache License 2.0
1.73k stars 486 forks source link

Merge Localizable strings #5325

Open stefanceriu opened 2 years ago

stefanceriu commented 2 years ago

In Element, we currently have 3 localization file schemes: 1) Vector.strings - main application translations 2) MatrixKit.strings - translation migrated from the MatrixKit 3) Localizable.strings - strings used only in the notification extension

We should merge all of them together into Vector and clean up Weblate. While merging the MatrixKit ones in is rather straight forward for 3) we will need to migrate from the localizedUserNotificationString method (which seems to only be useful for scheduled local notifications) to a normal swiftgen template one.

pixlwave commented 2 years ago

We should merge all of them together into Vector and clean up Weblate.

What would be the benefit of picking Vector.strings over Xcode's standard Localizable.strings?