search

element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 492 forks source link

Voiceover reports notification checkboxes as buttons #5596

Open tyrylu opened 2 years ago

tyrylu commented 2 years ago

Steps to reproduce

  1. Go to the notification settings, for example to other notification settings, but it does not matter, as long as the control is used

Outcome

What did you expect?

The checked/unchecked state would be reported

What happened instead?

Only "button" was reported regardless of the state

Your phone model

iPhone 11 pro

Operating system version

iOs 15.3.1

Application version

Element 1.7.0

Homeserver

Not relevant

Will you send logs?

No

pixlwave commented 2 years ago

This is on the SwiftUI components. Comparing to similar component in the Settings app, it looks like the expected label should be: Checked

Selected. Direct Messages.

and Unchecked

Direct Messages.

Whilst the component is a button, the display is really mimicking a picker, so it seems like Button is unexpected. @tyrylu does this all sound accurate to you?

tyrylu commented 2 years ago

Yes, that sounds about right. I would expect a switch there, or at least a selected/not selected suffix, likely in an a11y label.