element-hq / element-ios

A glossy Matrix collaboration client for iOS
https://element.io
GNU Affero General Public License v3.0
1.73k stars 497 forks source link

Read receipts from accounts who are not room members aren't displayed #5676

Open CarlAmbroselli opened 2 years ago

CarlAmbroselli commented 2 years ago

Steps to reproduce

When having bridged rooms (i.e. WhatsApp rooms) where the bridge bot sends m.read receipts to messages, these read avatar icons are only shown on Element iOS if the account that sent the read receipt is a member of the room (invited but not accepted is enough).

On Element Web these read markers are shown with initials, but no avatar is loaded.

The desired functionality would be if all read receipts are displayed in the iOS App (no matter if the account sending the read receipt is a member of the room or not). Bonus would be, if the avatar of the account gets shown correctly, rather than just the initial.

Reproduce

Outcome

What did you expect?

What happened instead?

Your phone model

iPhone 13 Pro

Operating system version

15.2.1

Application version

Element 1.8.1

Homeserver

Synapse 1.52.0

Will you send logs?

No

CarlAmbroselli commented 2 years ago

This seems to be the filter to only display read receipts for room members in the bubbles view: https://github.com/vector-im/element-ios/blob/17948e950232e1c32a6bcfd4bf3f3d414980bc84/Riot/Modules/Room/TimelineCells/Common/MXKRoomBubbleTableViewCell.m#L726-L734

Non-bubbles view: https://github.com/vector-im/element-ios/blob/9773e866065e7e9d37606232153d9419c9abc49f/Riot/Modules/Room/DataSources/RoomDataSource.m#L501-L509