Refine text actions in top bar in modals

element-hq / element-ios

A glossy Matrix collaboration client for iOS

https://element.io

Apache License 2.0

1.72k stars 480 forks source link

Open niquewoodhouse opened 2 years ago

niquewoodhouse commented 2 years ago

Does cancel make sense when there's no action being taken? EG https://github.com/vector-im/element-ios/issues/5795
Does close make more sense when there's no action being taken?

pixlwave commented 2 years ago

Adding what I'd expect as an iOS user:

A Cancel button would usually only be added when there's also another button for a confirmation action (either as the right hand bar button or in the modal itself).
Otherwise if the modal has no actions, I'd expect a confirmation button on the right side of the nav bar as either Done or the newer circular close button with an xmark that Apple is using more and more.